Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lambda runtime parity configuration for ulimit #7871

Merged
merged 14 commits into from
Mar 20, 2023
Merged

Add Lambda runtime parity configuration for ulimit #7871

merged 14 commits into from
Mar 20, 2023

Commits on Mar 20, 2023

  1. Add argparse POC for parse_additional_flags

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    8a2f41b View commit details
    Browse the repository at this point in the history

  2. Make parser compatible with older Python version

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a5ed008 View commit details
    Browse the repository at this point in the history

  3. Add label argument shortcut to match Docker API

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7566778 View commit details
    Browse the repository at this point in the history

  4. Order flags alphabetically

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7e5d650 View commit details
    Browse the repository at this point in the history

  5. Re-structure Docker additional flags parser 

    The list of optional argument is becoming hard to maintain when using implicit ordering.
Explicit key/value pairs make the usage of `parse_additional_flags` much clearer and easier.
    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c0d58c9 View commit details
    Browse the repository at this point in the history

  6. Add ulimit to Docker clients

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    ed4ce7c View commit details
    Browse the repository at this point in the history

  7. Simplify boolean flag parsing 

    We don't need to offer a no-privileged flag. Hence, we can simplify parsing of a boolean flag while maintaining compatibility for Python 3.7
    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    12d2053 View commit details
    Browse the repository at this point in the history

  8. Test lambda ulimits

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    19ece8a View commit details
    Browse the repository at this point in the history

  9. Add flags to run container

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    1fac0b7 View commit details
    Browse the repository at this point in the history

  10. Fix Python version compatibility issues 

    * Use Typings for older Python version
* Convert TypedDict into dataclass
    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6e7734d View commit details
    Browse the repository at this point in the history

  11. Skip ulimit test without Docker

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a002ab0 View commit details
    Browse the repository at this point in the history

  12. Fix stack ulimit for CI tests against pro

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4a29f2c View commit details
    Browse the repository at this point in the history

  13. Clarify test skip for legacy local executor

    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    1de8682 View commit details
    Browse the repository at this point in the history

  14. Add argparse custom action refactoring comment 

    Requires more testing to ensure consistent behavior (e.g., with multiple arguments, empty arguments, and combinations).
    @joe4dev
    joe4dev committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4301369 View commit details
    Browse the repository at this point in the history