Raise DependencyNotYetSatisfied instead of KeyError when secret is not yet populated

[dfangl]

Motivation

Currently, we just raise a KeyError when a key is not present in the secret we had a Ref to. However, it is possible that this key will be filled by another resource, for example a SecretTargetAttachement in the future, which was prevented by the immediate error.

Also, the Execution Status used for the short circuit condition is not actually available in the return value of the API call: https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_DescribeChangeSet.html

Changes

• Raise DependencyNotYetSatisfied instead of KeyError when secret is not yet populated, to be able to wait for another resource to populate it correctly. If this is never the case, the stack will still fail, but it will not fail immediately anymore on the first try.
• Raise a ShortCircuitWaitException when execution status is "EXECUTE_FAILED" instead of "ROLLBACK_COMPLETE".

[github-actions]

LocalStack Community integration with Pro

1 954 tests   1 718 ✔️  1h 14m 37s ⏱️
       2 suites     236 💤
       2 files           0 ❌

Results for commit b0468ff.

♻️ This comment has been updated with latest results.

[dominikschubert]

LGTM! Good catch 👍