New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor handling of CFn stack parameters #8322
Conversation
2781ff7
to
1277eda
Compare
@@ -1,40 +1,8 @@ | |||
import re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see much of a value at this point for these resolve unit tests since I'd prefer to use proper integration tests here soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to move this piece of the process to its proper place - before the template deployer gets created 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice to not have to deal with parameters in the deployer itself!
4b492d2
to
0916800
Compare
0916800
to
463a380
Compare
Changes
parameters.py
now, the responsibility is moved further up to the API provider to make this as transparent as possible.What hasn't changed
Stack.resources
for now. This will be split up in a future PR.Also note I didn't add further tests yet since I didn't want to bloat this too much. I've started on more parity focused tests but I want to give them a bit more polish and build a proper parameter test suite out of it first.