S3: Implement cross-account access #8395
Conversation
contingent to Moto PR being merged
viren-nadkarni
added
the
semver: minor
There was a problem hiding this comment.
LGTM! I've read the change in moto, and it's not only GetObject, PutObject and ListObjects anymore, right, but it's effectively every single S3 operation that is now cross-account enabled?
This might actually fix #7084!
This is very cool, I'm not sure how ACL are enforced on the moto side, but it should be okay. Awesome, thanks a lot for tackling this!
| Bucket="foo", | ||
| CreateBucketConfiguration={"LocationConstraint": SECONDARY_TEST_AWS_REGION_NAME}, | ||
| ) | ||
| exc.match("BucketAlreadyExists") |
There was a problem hiding this comment.
nit: I've tested against AWS and its missing a dot at the end of the exception message. Shouldn't be so bad, but we know some IaC/SDK are very picky about this message. I guess we should fix it in moto?
There was a problem hiding this comment.
Yes, this should be fixed in Moto. I'll try to remember to sneak a fix for this in my next moto PR
It may, but this definitely needs further testing before we can claim so! |
This PR adds tests for cross-account support to S3 for following operations:
The actual implementation was done in Moto in below linked PRs. This also introduces a shared namespace for buckets.
Depends on:
cc: @dfangl