add BodyS3Location property to AWS::ApiGateway::RestApi #8425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:cloudformation
bentsku
force-pushed
the
cfn/add-restapi-s3bodylocation
branch
from
510c40b
to
1faf6c5
Compare
bentsku
changed the title
bentsku
changed the title
bentsku
force-pushed
the
cfn/add-restapi-s3bodylocation
branch
from
1faf6c5
to
dd0649b
Compare
bentsku
force-pushed
the
cfn/add-restapi-s3bodylocation
branch
from
dd0649b
to
7cc6140
Compare
bentsku
force-pushed
the
cfn/add-restapi-s3bodylocation
branch
from
7cc6140
to
81aa7f2
Compare
dominikschubert
approved these changes
Jun 5, 2023
dominikschubert
approved these changes
Jun 5, 2023
bentsku
force-pushed
the
cfn/add-restapi-s3bodylocation
branch
from
81aa7f2
to
f573e97
Compare
calvernaz
approved these changes
Jun 5, 2023
| @@ -241,6 +241,8 @@ def update_rest_api( | |||
|
|
|||
| @handler("PutRestApi", expand=False) | |||
| def put_rest_api(self, context: RequestContext, request: PutRestApiRequest) -> RestApi: | |||
| # TODO: take into account the mode: overwrite or merge | |||
There was a problem hiding this comment.
yep, no "mode" means "merge" - not necessarily a fix for now, but we could return a non-supported error if the mode is overwrite
There was a problem hiding this comment.
Right, but right now we are not merging but always overwriting I believe? we do the following in the importer:
# Remove default root, then add paths from API spec
rest_api.resources = {}
bentsku
force-pushed
the
cfn/add-restapi-s3bodylocation
branch
from
f573e97
to
df720b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8371
Implementing the
BodyS3Locationproperty toAWS::ApiGateway::RestApias requested by a customer.This property allows Cloudformation to directly fetch the "Body" property from an S3 bucket.
However, I am not sure how to do negative testing with Cloudformation, so for now any S3 exception is going to bubble up?
Small note: I've also removed a line from the API Gateway importer because it was erasing tags after updating a RestAPI, which is not the default mode anymore.
Resource:
https://docs.aws.amazon.com/fr_fr/AWSCloudFormation/latest/UserGuide/aws-properties-apigateway-restapi-s3location.html