New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make store lookups for Events rule jobs request context aware #8469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi @embano1 . The issue you've reported could potentially be resolved with this change: https://github.com/localstack/localstack/pull/8469/files#diff-e93fb0ca12285e3a1b71692d6dcae8cf7333857a6019bbe5af6115615541d088R519-R521 The |
@whummer you're awesome, will try ASAP and report back in the issue! |
@whummer been 3h since you merged and Docker Hub still shows the old one from 7h ago |
@embano1 , looks like indeed we had some flakiness in our CI pipeline, re-triggered the build one more time, should hopefully update the latest image soon. You can follow the progress here: https://app.circleci.com/pipelines/github/localstack/localstack?branch=master Thanks |
@whummer great, thx a bunch! |
Make store lookups for Events rule jobs request context aware. This issue surfaced when restoring rule jobs from persistence/pods (companion PR following soon).
At its core, the PR replaces
aws_stack.connect_to_service(..)
calls with in-memory lookups, and addsEventsStore
as a parameter for theget_scheduled_rule_func
/put_rule_job_scheduler
util methods, to ensure we're targeting the right account/region./cc @giograno
Summary of changes:
get_store(..)
, to extract account/region directly from thecontext
objectEventsStore
as a parameter for theget_scheduled_rule_func
/put_rule_job_scheduler
util methodsget_event_bus_name(..)
util function that extracts the bus name from a name/ARN, or returns thedefault
event bus as a fallback