Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix apigateway issue with logging template #8496

Merged
merged 1 commit into from Jun 14, 2023
Merged

fix apigateway issue with logging template #8496

merged 1 commit into from Jun 14, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jun 13, 2023

Fix an issue when issuing a log warning, I missed a string interpolation %s and provided 3 parameters for only 2 %s.

This will fix it.

@bentsku bentsku requested a review from calvernaz as a code owner June 13, 2023 15:46
@bentsku bentsku added the semver: patch Non-breaking changes which can be included in patch releases label Jun 13, 2023
@bentsku bentsku self-assigned this Jun 13, 2023
@bentsku bentsku added the aws:apigateway Amazon API Gateway label Jun 13, 2023
@bentsku bentsku requested a review from thrau June 13, 2023 15:47
@coveralls
Copy link

Coverage Status

coverage: 82.674% (+0.02%) from 82.655% when pulling 939730a on fix-apigw-import-log into 8321224 on master.

@github-actions
Copy link

github-actions bot commented Jun 13, 2023 •
edited

LocalStack Community integration with Pro

       2 files         2 suites   1h 26m 57s ⏱️
2 092 tests 1 808 ✔️ 284 💤 0 ❌
2 093 runs  1 808 ✔️ 285 💤 0 ❌

Results for commit 939730a.

♻️ This comment has been updated with latest results.

@bentsku bentsku merged commit bdaee1e into master Jun 14, 2023
29 checks passed
@bentsku bentsku deleted the fix-apigw-import-log branch June 14, 2023 05:20
simonrw pushed a commit that referenced this pull request Jun 14, 2023
@bentsku @simonrw
fix apigateway issue with logging when importing (#8496)
c8d5af3
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvernaz calvernaz calvernaz approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@bentsku bentsku

Labels
aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bentsku @coveralls @calvernaz @dfangl