CFn: simplify "result_handler" function signature #8529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
dominikschubert
force-pushed
the
cfn/simplify-params-helper
branch
from
f3c86b1
to
e32fd10
Compare
simonrw
force-pushed
the
cfn/simplify-result-result-handler
branch
from
70ed2d7
to
500b8e4
Compare
dominikschubert
requested review from
dominikschubert,
thrau,
baermat,
bentsku,
macnev2013,
alexrashed,
steffyP,
joe4dev,
dfangl and
viren-nadkarni
as code owners
dominikschubert
removed request for
alexrashed,
thrau,
viren-nadkarni,
steffyP,
joe4dev,
macnev2013,
dfangl,
bentsku and
baermat
dominikschubert
force-pushed
the
cfn/simplify-result-result-handler
branch
from
f9fef28
to
adfe3af
Compare
dominikschubert
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update signature of the "result_handler" functions to remove unused parameters, and parameters that the provider should not have access to, particularly the full list of resource definitions.
This work is in preparation of integrating the new resource providers into the template deployer.