add config variable to explicitly ignore AWS credentials #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
added
the
semver: patch
| @@ -103,9 +103,10 @@ def get_account_id_from_access_key_id(access_key_id: str) -> str: | |||
| if not config.PARITY_AWS_ACCESS_KEY_ID: | |||
| # If AWS_ACCESS_KEY_ID has production AWS credentials, ignore them | |||
| if access_key_id.startswith("ASIA") or access_key_id.startswith("AKIA"): | |||
| LOG.warning( | |||
There was a problem hiding this comment.
I would prefer changing the log level here to debug than adding yet another config option which simply supresses a single log message.
There was a problem hiding this comment.
Hard to say, I think. People are using DEBUG=1 very often, so it might still spam them. Then, on the other hand, I think warning is the correct log level, as it is something unexpected happening, not just some site note to a expected flow.
I am okay with either way. I agree with this approach not scaling in the future but on the other hand it does not really fit the "debug" logs.
In any case, I think it only solves #8380, and not the other issue (we need to investigate where these "production" credentials come from there).
dfangl
force-pushed
the
squelch-aws-credentials-logs
branch
from
630f19b
to
e606e8b
Compare
viren-nadkarni
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick fix for #8225 and #8380
i'd like to get some input from @dfangl and @viren-nadkarni whether this makes sense and is something we can expand on.