Adds HTTP integration URIs #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
calvernaz
added
the
semver: patch
bentsku
reviewed
Jun 30, 2023
There was a problem hiding this comment.
LGTM! This is awesome, thanks for adding this feature so quickly, sorry for the delay in reviewing.
It would be nice if we could validate it against AWS, even if it seems obvious this will work against it, just so that we have the marker and we have confidence it runs (also for maybe future automated tests against AWS). I've left a comment regarding a fixture that can be used to run against AWS as well.
Thanks again! Also, awesome use of the import feature that makes it so much simpler to set up simple resources instead of so many direct SDK calls. 🚀
(cherry picked from commit c239fc0)
calvernaz
force-pushed
the
8567-bug-stage-variables-not-evaluated-for-http-integration-uri
branch
from
97ee786
to
70a76cd
Compare
whummer
approved these changes
Jul 2, 2023
There was a problem hiding this comment.
LGTM 🚀 - kudos @calvernaz for adding the AWS validated test.
bentsku
approved these changes
Jul 3, 2023
calvernaz
deleted the
8567-bug-stage-variables-not-evaluated-for-http-integration-uri
branch
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for HTTP integration URIs https://docs.aws.amazon.com/apigateway/latest/developerguide/aws-api-gateway-stage-variables-reference.html