Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ListRoles operation with PermissionsBoundary attached #8614

Merged
merged 2 commits into from Jul 5, 2023
Merged

Fix ListRoles operation with PermissionsBoundary attached #8614

merged 2 commits into from Jul 5, 2023

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Jul 4, 2023 •
edited

Motivation

Currently, if a role has a PermissionsBoundary attached, the ListRoles operation fails with a serializer error.

This is due to the returning of the unexpected PermissionsBoundary field in the to-be-serialized response.

Fixes #7779

Changes

  • Add new fields to iam_api snapshot transformer
  • Remove removal of MaxSessionDuration from model, it should only not be returned in the CreateRole call
  • Add aws validated + snapshotted tests for the MaxSessionDuration and the PermissionsBoundary behavior.

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jul 4, 2023
@coveralls
Copy link

Coverage Status

coverage: 82.605% (-0.1%) from 82.733% when pulling eda8e58 on fix-iam-role-permission-boundaries into c758aae on master.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 20m 55s ⏱️
2 176 tests 1 845 ✔️ 331 💤 0 ❌
2 177 runs  1 845 ✔️ 332 💤 0 ❌

Results for commit eda8e58.

dominikschubert
dominikschubert approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dfangl dfangl merged commit ac78d6f into master Jul 5, 2023
24 checks passed
@dfangl dfangl deleted the fix-iam-role-permission-boundaries branch July 5, 2023 11:28
calvernaz pushed a commit that referenced this pull request Jul 5, 2023
@dfangl @calvernaz
fix ListRoles operation with PermissionsBoundary attached (#8614)
aa77c11
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@steffyP steffyP Awaiting requested review from steffyP steffyP is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

bug: Cannot list roles which have permission boundaries attached
3 participants
@dfangl @coveralls @dominikschubert