Fix error with non-existent policy for AttachRolePolicy operation #8615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfangl
changed the title
AttachRolePolicy
dfangl
added
the
semver: patch
dfangl
force-pushed
the
fix-iam-key-error
branch
from
7524951
to
6f7bdd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we do not properly verify the policy arn in the
attach_*_policymethods, and have not tests for this behavior.Depens on getmoto/moto#6482 , fixes #7934 .
Ext Test run (due to snapshot transform changes): https://github.com/localstack/localstack-ext/actions/runs/5522309201
Changes