Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting custom Unpickler #8635

Merged
merged 1 commit into from Jul 6, 2023
Merged

Deleting custom Unpickler #8635

merged 1 commit into from Jul 6, 2023

Conversation

giograno
Copy link
Member

@giograno giograno commented Jul 6, 2023

Removing our custom Unpickler from the current implementation, as briefly discussed with @thrau.
To the best of my understanding, dispatch_tables are specific to Picklers only (docs).

cc @whummer

@giograno
Removing custom Unpickler
425094d 
        Current implementation seems redundant (removing it seems to
        solve some issue when restoring CrossRegionAttributes)
@giograno giograno added area: persistence Retain state between LocalStack runs semver: patch Non-breaking changes which can be included in patch releases labels Jul 6, 2023
@giograno giograno self-assigned this Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 32m 23s ⏱️
2 179 tests 1 849 ✔️ 330 💤 0 ❌
2 180 runs  1 849 ✔️ 331 💤 0 ❌

Results for commit 425094d.

@giograno
Copy link
Member Author

giograno commented Jul 6, 2023

Failing test TestLambdaOutgoingSdkCalls::test_lambda_send_message_to_sqs[python3.8] does not concern this PR.

@giograno giograno requested review from thrau and whummer July 6, 2023 12:44
@giograno giograno marked this pull request as ready for review July 6, 2023 12:44
thrau
thrau approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this. And sorry for not documenting it properly in the first place!

@thrau thrau merged commit b78b678 into master Jul 6, 2023
26 of 27 checks passed
@thrau thrau deleted the clean-unpickler branch July 6, 2023 18:06
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@whummer whummer Awaiting requested review from whummer

Assignees

@giograno giograno

Labels
area: persistence Retain state between LocalStack runs semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giograno @thrau @dfangl