Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ses: add validation for email tags #8639

Merged
merged 7 commits into from Jul 7, 2023
Merged

ses: add validation for email tags #8639

merged 7 commits into from Jul 7, 2023

Conversation

sannya-singal
Copy link
Contributor

This PR adds validation for send_email tags and a test case to verify the results against AWS.

Related issue: #8588.

@sannya-singal sannya-singal added aws:ses Amazon Simple Email Service semver: patch Non-breaking changes which can be included in patch releases labels Jul 6, 2023
@sannya-singal sannya-singal self-assigned this Jul 6, 2023
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but LGTM otherwise ✔️

For future work, we can create a general purpose tag validation library that can be used for other resources too

}
}
},
"tests/integration/test_ses.py::TestSES::test_invalid_tags_send_email[test_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_len-test]": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also be printed in output logs. Consider using param ID to avoid this.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 26m 14s ⏱️
2 197 tests 1 863 ✔️ 334 💤 0
2 198 runs  1 863 ✔️ 335 💤 0

Results for commit 6545cd3.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Coverage Status

coverage: 82.856% (-0.003%) from 82.859% when pulling 6545cd3 on send-email-tags into 9f6af09 on master.

@sannya-singal sannya-singal merged commit edc9265 into master Jul 7, 2023
24 checks passed
@sannya-singal sannya-singal deleted the send-email-tags branch July 7, 2023 07:10
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:ses Amazon Simple Email Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants