New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ses: add validation for email tags #8639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but LGTM otherwise ✔️
For future work, we can create a general purpose tag validation library that can be used for other resources too
} | ||
} | ||
}, | ||
"tests/integration/test_ses.py::TestSES::test_invalid_tags_send_email[test_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_lentest_invalid_name_len-test]": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also be printed in output logs. Consider using param ID to avoid this.
3f3e1c5
to
6545cd3
Compare
This PR adds validation for
send_email
tags and a test case to verify the results against AWS.Related issue: #8588.