A try fixing Lambda persistence #8643
Conversation
dfangl
added
the
semver: patch
| @@ -64,6 +64,9 @@ | |||
| SNAP_START_SUPPORTED_RUNTIMES = [Runtime.java11, Runtime.java17] | |||
|
|
|||
|
|
|||
| BUCKET_ACCOUNT = "949334387222" | |||
There was a problem hiding this comment.
It would be helpful to add a comment clarifying that this is just some random account
| @@ -64,6 +64,9 @@ | |||
| SNAP_START_SUPPORTED_RUNTIMES = [Runtime.java11, Runtime.java17] | |||
|
|
|||
|
|
|||
| BUCKET_ACCOUNT = "949334387222" | |||
There was a problem hiding this comment.
✅ We don't get any conflicts in multi-account setups because the account_id is used as namespace
| @@ -64,6 +64,9 @@ | |||
| SNAP_START_SUPPORTED_RUNTIMES = [Runtime.java11, Runtime.java17] | |||
|
|
|||
|
|
|||
| BUCKET_ACCOUNT = "949334387222" | |||
There was a problem hiding this comment.
semver:minor
There was a problem hiding this comment.
The recent cross-account enhancements as well, so good to batch them: 28427b9
There was a problem hiding this comment.
This is actually a fix for that PR, as it broke persistence for remote fetched layers. Not exactly sure why currently, but it blocks the -ext pipeline.
| @@ -64,6 +64,9 @@ | |||
| SNAP_START_SUPPORTED_RUNTIMES = [Runtime.java11, Runtime.java17] | |||
|
|
|||
|
|
|||
| BUCKET_ACCOUNT = "949334387222" | |||
There was a problem hiding this comment.
"Hiding" LocalStack-internal lambda buckets basically addresses this question #8494
dfangl
added
semver: minor
Motivation
With PR #8235 , the persistence tests broke.
It seems, that connecting to the bucket from different accounts, made some problems with remote fetched layers. It is not quite clear what causes this behavior (maybe some cross account problem in s3?), but it needs to be solved ASAP to unblock the pipeline.
Changes
@giograno