Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize extra cors allowed origins #8644

Merged
merged 1 commit into from Jul 10, 2023
Merged

sanitize extra cors allowed origins #8644

merged 1 commit into from Jul 10, 2023

Conversation

lukqw
Copy link
Member

@lukqw lukqw commented Jul 6, 2023 •
edited

This PR adds a sanitization step when parsing origins from `EXTRA_CORS_ALLOWED_ORIGINS.

This is mainly to filter out "" when it's specified by accident, or intentionally.

@lukqw lukqw requested a review from thrau as a code owner July 6, 2023 17:40
@lukqw lukqw added the semver: patch Non-breaking changes which can be included in patch releases label Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 21m 2s ⏱️
2 187 tests 1 853 ✔️ 334 💤 0 ❌
2 188 runs  1 853 ✔️ 335 💤 0 ❌

Results for commit 2387ca3.

@thrau thrau requested a review from dfangl July 7, 2023 07:50
dfangl
dfangl approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But please add in the PR description why this change is necessary, e.g. the case how the excess spaces were provided.

@lukqw lukqw merged commit 9eb3dff into master Jul 10, 2023
23 of 28 checks passed
@lukqw lukqw deleted the extra-cors-sanitizer branch July 10, 2023 13:36
@dfangl dfangl added this to the 2.2 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukqw @dfangl