Remove usage of GenericBaseModel outside of LegacyResourceProvider #8711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
added
the
semver: patch
dominikschubert
force-pushed
the
cfn-remove-usage-of-genericbasemodel
branch
from
57d9a84
to
14cef9a
Compare
dominikschubert
commented
Jul 18, 2023
| @@ -328,7 +328,7 @@ def test_describe_change_set_nonexisting(snapshot, aws_client): | |||
| snapshot.match("exception", ex.value) | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(reason="fails because of the properties mutation in the result_handler") | |||
| @pytest.mark.skip(reason="fails because of the properties mutation in the result_handler") | |||
There was a problem hiding this comment.
don't see a point in waiting 5min for all the timeouts here, so this should speed up the tests a bit 😅
dominikschubert
commented
Jul 18, 2023
|
|
||
| if config.CFN_IGNORE_UNSUPPORTED_RESOURCE_TYPES: | ||
| # TODO: figure out a better way to handle non-implemented here? | ||
| return ProgressEvent(OperationStatus.SUCCESS, resource_model={}) |
There was a problem hiding this comment.
not sure about the returned model here
dominikschubert
requested review from
dfangl,
pinzon,
simonrw and
thrau
as code owners
dominikschubert
added
semver: minor
simonrw
approved these changes
Jul 18, 2023
dominikschubert
force-pushed
the
cfn-remove-usage-of-genericbasemodel
branch
from
cd5675f
to
2ff3f6c
Compare
dominikschubert
force-pushed
the
cfn-remove-usage-of-genericbasemodel
branch
from
bd66bc2
to
5cbb717
Compare
dominikschubert
force-pushed
the
cfn-remove-usage-of-genericbasemodel
branch
from
5cbb717
to
889a301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CFN_IGNORE_UNSUPPORTED_RESOURCE_TYPESconfig variable to determine if we should fail if a resource type doesn't exist. E.g. settingCFN_IGNORE_UNSUPPORTED_RESOURCE_TYPES=0will cause a stack deployment to fail if the resource type doesn't have an associated provider.RESOURCE_MODELS, i.e. the GenericBaseModel classes in the template_deployer, except the current fallback for retrievingFn::GetAtttargets that still needs to use them. If we refactor the models to remove allget_cfn_attributecalls, we can delete this completely.retrieve_resource_detailsextract_resource_attributeresolve_refget_resource_model_instanceinvoke_function(unused)get_ref_from_model=> simple physical resource ID lookup nowdetermine_resource_physical_id=> simple physical resource ID lookup nowis_deployable_resourceandis_updateable=> everything should be a "deployable resource" andis_updateableis now only used in theLegacyResourceProviderupdate_resource_details=> this was a bit of a headache unfortunately since it was responsible for populating the_state_, i.e. the result of the fetch_state call in the models. This initially broke UPDATEs on the old models. I've introduced a workaround for Add and Modify operations in the LegacyResourceProvider. It's a bit hacky but we also shouldn't let those currently 15 resources with (partial) UPDATE support live for too long as GenericBaseModels anyway.GenericBaseModel.get_refGenericBaseModel.fetch_state_if_missing