Remove get_cfn_attribute from legacy models #8717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
force-pushed
the
cfn-remove-get-cfn-attribute
branch
from
b6b6d47
to
314b827
Compare
dominikschubert
added
the
semver: patch
dominikschubert
changed the title
dominikschubert
requested review from
baermat,
bentsku,
macnev2013,
steffyP,
joe4dev,
dfangl,
alexrashed,
viren-nadkarni,
pinzon and
simonrw
as code owners
dominikschubert
removed request for
alexrashed,
thrau,
viren-nadkarni,
steffyP,
joe4dev,
macnev2013,
dfangl,
bentsku and
baermat
dominikschubert
commented
Jul 27, 2023
Comment on lines
91
to
96
| if "." in attribute_name: | ||
| parts = attribute_name.split(".") | ||
| attribute = self.props | ||
| for part in parts: | ||
| attribute = attribute.get(part) | ||
| return attribute |
There was a problem hiding this comment.
just temporary, since this whole method will soon be removed. this will enable resolving properties like Outputs.NestedStackOutputA
dominikschubert
commented
Jul 28, 2023
Comment on lines
+18
to
+23
| # def fetch_state(self, stack_name, resources): | ||
| # client = connect_to().cloudformation | ||
| # child_stack_name = self.props["StackName"] | ||
| # result = client.describe_stacks(StackName=child_stack_name) | ||
| # result = (result.get("Stacks") or [None])[0] | ||
| # return result |
There was a problem hiding this comment.
commented out for now, I'll probably churn through the models and check where we can delete fetch_state implementations after the two PRs are merged 😄
simonrw
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all usage of
get_cfn_attributefrom the community resource models.It does not yet introduce a subset selection for the migrated resources to stay in parity with the previous behavior for now where we nearly always fall back to a direct property/state lookup.
A follow-up PR will soon remove the base method from the GenericBaseModel and unify the code paths between old and legacy providers.