DynamoDB: Use fixtures to create and clean up test tables #8747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
the
semver: patch
This was referenced Jul 26, 2023
dominikschubert
approved these changes
Jul 28, 2023
tests/integration/test_dynamodb.py
Outdated
| """ | ||
| This fixture returns a DynamoDB table for testing. | ||
| """ | ||
| table_name = "ddb-test-table" |
There was a problem hiding this comment.
Suggested change
| table_name = "ddb-test-table" | |
| table_name = "ddb-test-table" |
Would suggest making this unique to avoid any potential issues/conflicts and allow for potential parallelization in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small improvement to the DynamoDB test suite.
Test table names that were earlier decalared as constants are now converted to fixtures which do proper clean up after tests finish.