Refactor unittest integration tests to use pytest
#8749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
the
semver: patch
viren-nadkarni
force-pushed
the
refactor-unittest-to-pytest
branch
from
36a830a
to
ad7eda5
Compare
viren-nadkarni
force-pushed
the
refactor-unittest-to-pytest
branch
from
a15647f
to
39b969d
Compare
viren-nadkarni
force-pushed
the
refactor-unittest-to-pytest
branch
from
982d85f
to
28bfc56
Compare
viren-nadkarni
requested review from
joe4dev,
dfangl and
dominikschubert
as code owners
dfangl
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors some of our older integration tests from
unittesttopytest.This will allow use of modern fixtures,
aws_client,aws_client_factory,secondary_aws_clientetc., that use the new internal client factory. Consequently, this will help improve test coverage for cross- and multi-account setups.