fix S3 lifecycle rule matching with ExpiredObjectDeleteMarker #8752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8750
We didn't consider the case where
ExpiredObjectDeleteMarkerwould be set in theExpirationfield of rule. Basically, if this is set, you can't setDaysorDateso we would serialize a proper header (and we should not).Adjusted the logic to properly parse the lifecycle configuration so that we can't have
DaysorDateset withExpiredObjectDeleteMarker, and adjusted the matching so that we wouldn't return a rule that containsExpiredObjectDeleteMarker, because you shouldn't serialize a header then.