Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix S3 case where aws-chunked chunk is bigger than read size #8760

Merged
merged 1 commit into from Jul 27, 2023
Merged

fix S3 case where aws-chunked chunk is bigger than read size #8760

merged 1 commit into from Jul 27, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Jul 27, 2023

This PR fix the newly arised issue #8756

Basically we were missing a reset to the signal for the end of a chunk. Quick fix, and added a test covering this case.

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases labels Jul 27, 2023
@bentsku bentsku requested a review from alexrashed July 27, 2023 15:53
@bentsku bentsku self-assigned this Jul 27, 2023
@bentsku bentsku requested a review from macnev2013 as a code owner July 27, 2023 15:53
@coveralls
Copy link

Coverage Status

coverage: 82.391% (+0.006%) from 82.385% when pulling 507ddcc on fix-s3-aws-chunked-decoder into ea7f26b on master.

alexrashed
alexrashed approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 1 LoC in the logic, dozens of lines for a (really nice) test! 🚀

@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 20m 21s ⏱️
2 247 tests 1 903 ✔️ 344 💤 0 ❌
2 248 runs  1 903 ✔️ 345 💤 0 ❌

Results for commit 507ddcc.

@bentsku bentsku merged commit 3922cf4 into master Jul 27, 2023
30 checks passed
@bentsku bentsku deleted the fix-s3-aws-chunked-decoder branch July 27, 2023 17:24
@bentsku bentsku linked an issue Jul 27, 2023 that may be closed by this pull request
bug: error on multipart upload to S3 #8756
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: error on multipart upload to S3
3 participants
@bentsku @coveralls @alexrashed