improve docker integration with localstack start command

[thrau]

Motivation

There were a few things that bothered me about the localstack start command:

• No first-class flags for operations i need often (specifying the docker network, adding environment variables), I dislike using the DOCKER_FLAGS for common stuff
• If the docker image is not there, localstack didn't really tell you, and would be pulled implicitly sometime during the startup procedure.
• The "Localstack Runtime Log" ruler wasn't placed correctly

Changes

• added a --network and -e flag to localstack start which are handed down to the docker run command. for that i needed to hand down the CLI parameters to the plumbing
• added a check that creates the specified network if it doesn't exist yet
• added an ensure_container_image method that checks whether the requested container image is there, and if not, pulls it explicitly (+status indicator)
• added a console status indicator for while the localstack container is still starting up.

Startup without docker image

Here's what the startup looks like now

Peek.2023-07-30.20-43_edit.mp4

LocalStack Runtime Log Rule

Before/After (not quite the same startup procedure though, but note the rule is right before the

Network

A custom network is much easier now. localstack as network could be the default at some point? (cc @cabeaulac @simonrw).

python -m localstack.cli.main start --network localstack

docker run --rm -it --network=localstack curlimages/curl http://localstack_main:4566/_localstack/health
{"services": {"acm": "available", "apigateway": "available", "cloudformation": "available", "cloudwatch": "available", "config": "available", "dynamodb": "available", "dynamodbstreams": "available", "ec2": "available", "es": "available", "events": "available", "firehose": "available", "iam": "available", "kinesis": "available", "kms": "available", "lambda": "available", "logs": "available", "opensearch": "available", "redshift": "available", "resource-groups": "available", "resourcegroupstaggingapi": "available", "route53": "available", "route53resolver": "available", "s3": "available", "s3control": "available", "secretsmanager": "available", "ses": "available", "sns": "available", "sqs": "available", "ssm": "available", "stepfunctions": "available", "sts": "available", "support": "available", "swf": "available", "transcribe": "available", "sso-admin": "available"}, "version": "2.1.1.dev"}

TODO

• builds on use ContainerConfiguration object for LocalstackContainer #8771

[github-actions]

LocalStack Community integration with Pro

       2 files         2 suites   1h 32m 5s ⏱️
2 278 tests 1 919 ✔️ 359 💤 0 ❌
2 279 runs  1 919 ✔️ 360 💤 0 ❌

Results for commit 7493e9d.

♻️ This comment has been updated with latest results.

[alexrashed]

Nice! These new features and small UX improvements are looking good!
For now, I just had some minor nitpicks. There are still some TODOs and FIXMEs in the code, but I guess some of them might stay there for the first iteration. 🚀