Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pytest-tinybird to all CI runs on master #8807

Merged
merged 2 commits into from Aug 4, 2023
Merged

add pytest-tinybird to all CI runs on master #8807

merged 2 commits into from Aug 4, 2023

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Aug 2, 2023 •
edited

This PR adds the pytest-tinybird plugin to the test dependencies and modifies all GitHub and CircleCI test workflows such that they send the test data to the Tinybird workspace localstack_ci (if the pipeline is executed on master).
This data-driven approach will help us to gain more insights into our tests (automatically identify flaky tests, create individual health dashboards, setup a notification infrastructure,...).

TODO:

  • Check that data from all pipelines is sent correctly.
    • CircleCI
      • Run Locally (make test-coverage)
        • itest-s3-stream-provider
        • itest-lambda-legacy-local
        • itest-sfn-v2-provider
        • unit-tests
      • Run in Docker (make docker-run-tests)
        • docker-test-arm64
        • docker-test-amd64
    • GitHub
      • cli-tests
      • Community Integration Tests against Pro
      • tests-podman
  • Switch branch filter to master once the changes have been tested.
  • (Right before the merge) Truncate all data sources before merging (fresh start).

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 2, 2023
@alexrashed alexrashed marked this pull request as draft August 2, 2023 13:56
@coveralls
Copy link

coveralls commented Aug 2, 2023 •
edited

Coverage Status

coverage: 82.717% (+0.04%) from 82.677% when pulling fd67327 on add-pytest-tinybird into e1069ef on master.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited

LocalStack Community integration with Pro

       2 files         2 suites   1h 30m 28s ⏱️
2 299 tests 1 922 ✔️ 376 💤 1 ❌
2 300 runs  1 922 ✔️ 377 💤 1 ❌

For more details on these failures, see this check.

Results for commit e483df2.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed force-pushed the add-pytest-tinybird branch 4 times, most recently from e0c2dd5 to f481bf1 Compare August 3, 2023 11:24
@alexrashed alexrashed requested a review from steffyP August 3, 2023 12:20
@alexrashed alexrashed marked this pull request as ready for review August 3, 2023 12:20
@alexrashed
Copy link
Member Author

FYI: The Podman Docker Client Tests are currently also failing on the master branch.

thrau
thrau approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! looking forward to the results!

@alexrashed alexrashed merged commit ad2f7e0 into master Aug 4, 2023
8 of 12 checks passed
@alexrashed alexrashed deleted the add-pytest-tinybird branch August 4, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@steffyP steffyP Awaiting requested review from steffyP

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexrashed @coveralls @thrau