Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing lambda keepalive variable in to-pass list for CLI #8808

Merged
merged 1 commit into from Aug 2, 2023
Merged

fix missing lambda keepalive variable in to-pass list for CLI #8808

merged 1 commit into from Aug 2, 2023

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Aug 2, 2023

Fixes #8805

Currently, we do not pass LAMBDA_KEEPALIVE_MS from the CLI to the container, this was an oversight which is now corrected.

@dfangl dfangl requested a review from thrau as a code owner August 2, 2023 14:58
@dfangl dfangl requested a review from joe4dev August 2, 2023 14:58
@coveralls
Copy link

Coverage Status

coverage: 82.699% (-0.02%) from 82.722% when pulling 8609889 on fix-missing-cli-lambda-keepalive into 838f1ff on master.

joe4dev
joe4dev approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Set the label semver:patch

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Aug 2, 2023
@thrau thrau merged commit a326a16 into master Aug 2, 2023
24 of 27 checks passed
@thrau thrau deleted the fix-missing-cli-lambda-keepalive branch August 2, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: LAMBDA_KEEPALIVE_MS is not set in LocalStack container
4 participants
@dfangl @coveralls @joe4dev @thrau