Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cfn: Multi-accounts compatibility #8822

Merged
merged 1 commit into from Aug 23, 2023
Merged

Cfn: Multi-accounts compatibility #8822

merged 1 commit into from Aug 23, 2023

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Aug 4, 2023 •
edited

This PR adds account and region awareness to Cloudformation.

It will now be possible to deploy Cfn stack in any arbitrary account ID and any region.

Specifically, this PR makes the following changes:

  • Take the account ID and region name from Request Context and explicitly pass it down the call stack
  • Use these values when instantiating connect_to() clients and doing internal cross-service calls
  • Remove use of aws_stack.get_region() and get_account_id()

@viren-nadkarni viren-nadkarni self-assigned this Aug 4, 2023
@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited

LocalStack Community integration with Pro

       2 files         2 suites   1h 26m 33s ⏱️
2 080 tests 1 658 ✔️ 422 💤 0 ❌
2 081 runs  1 658 ✔️ 423 💤 0 ❌

Results for commit 97ad6a4.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni force-pushed the cfn-multi-accounts branch 9 times, most recently from b12280a to fb9d59b Compare August 5, 2023 07:48
@viren-nadkarni viren-nadkarni mentioned this pull request Aug 5, 2023
Closed
@viren-nadkarni viren-nadkarni force-pushed the cfn-multi-accounts branch 15 times, most recently from 5ff123c to de3ce03 Compare August 10, 2023 08:13
@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited

Coverage Status

coverage: 81.816% (+0.009%) from 81.807% when pulling dcb4195 on cfn-multi-accounts into 82bc739 on master.

@viren-nadkarni viren-nadkarni force-pushed the cfn-multi-accounts branch 3 times, most recently from 2b850c4 to dcb4195 Compare August 10, 2023 16:04
@viren-nadkarni viren-nadkarni marked this pull request as draft August 10, 2023 16:04
@viren-nadkarni viren-nadkarni marked this pull request as ready for review August 11, 2023 05:43
@viren-nadkarni viren-nadkarni added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: patch Non-breaking changes which can be included in patch releases labels Aug 14, 2023
dominikschubert
dominikschubert approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this 👍

@viren-nadkarni viren-nadkarni merged commit 1532604 into master Aug 23, 2023
25 checks passed
@viren-nadkarni viren-nadkarni deleted the cfn-multi-accounts branch August 23, 2023 05:31
@viren-nadkarni viren-nadkarni mentioned this pull request Aug 23, 2023
Merged
@dominikschubert dominikschubert mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

Assignees

@viren-nadkarni viren-nadkarni

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viren-nadkarni @coveralls @dominikschubert