Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aws client fixtures to conftest.py #8839

Merged
merged 4 commits into from Aug 7, 2023

Conversation

dominikschubert
Copy link
Member

Fixes resolving of fixtures / autocompletion for PyCharm. When we moved them to fixtures.py PyCharm wasn't able to properly resolve the fixtures for some reason which has a simple workaround: moving them to conftest.py.

@dominikschubert dominikschubert self-assigned this Aug 7, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Aug 7, 2023
@coveralls
Copy link

Coverage Status

coverage: 82.703% (+0.005%) from 82.698% when pulling db59bbd on fix-awsclient-autocompletion into 3721ddb on master.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 23m 24s ⏱️
2 316 tests 1 923 ✔️ 393 💤 0
2 317 runs  1 923 ✔️ 394 💤 0

Results for commit db59bbd.

Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this over!

@dominikschubert dominikschubert merged commit 5a368bc into master Aug 7, 2023
25 checks passed
@dominikschubert dominikschubert deleted the fix-awsclient-autocompletion branch August 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants