Mark deprecated env config options #8913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
the
semver: patch
viren-nadkarni
force-pushed
the
deprecated-options
branch
from
5f3651e
to
6f8c108
Compare
viren-nadkarni
commented
Aug 16, 2023
Comment on lines
+239
to
+243
| EnvVarDeprecation( | ||
| "KINESIS_INITIALIZE_STREAMS", | ||
| "1.4.0", | ||
| "This feature is marked for removal. Please use AWS client API to seed Kinesis streams.", | ||
| ), |
There was a problem hiding this comment.
deprecated in #7230
viren-nadkarni
commented
Aug 16, 2023
Comment on lines
+244
to
+258
| EnvVarDeprecation( | ||
| "ES_CUSTOM_BACKEND", | ||
| "0.14.0", | ||
| "This option is marked for removal. Please use OPENSEARCH_CUSTOM_BACKEND instead.", | ||
| ), | ||
| EnvVarDeprecation( | ||
| "ES_MULTI_CLUSTER", | ||
| "0.14.0", | ||
| "This option is marked for removal. Please use OPENSEARCH_MULTI_CLUSTER instead.", | ||
| ), | ||
| EnvVarDeprecation( | ||
| "ES_ENDPOINT_STRATEGY", | ||
| "0.14.0", | ||
| "This option is marked for removal. Please use OPENSEARCH_ENDPOINT_STRATEGY instead.", | ||
| ), |
There was a problem hiding this comment.
deprecated in #5341
viren-nadkarni
commented
Aug 16, 2023
localstack/deprecations.py
Outdated
Comment on lines
259
to
264
| EnvVarDeprecation( | ||
| "SERVICES", | ||
| "2.0.0", | ||
| "This option is marked for removal. LocalStack lazy loads services by default. " | ||
| "You may use EAGER_SERVICE_LOADING to load all services at startup. ", | ||
| ), |
There was a problem hiding this comment.
deprecated in #6438
viren-nadkarni
force-pushed
the
deprecated-options
branch
from
6ae6ae7
to
8e71e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the environment config options did not raise the deprecation warning when used. Although our docs correctly mentioned them as deprecated.
Implementation
This PR adds marks them as such.
To-do
SERVICESas deprecatedRelated
See localstack/docs#763 where this is synced.