New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda invocation loop rework #8970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
added
the
semver: minor
Non-breaking changes which can be included in minor releases, but not in patch releases
label
Aug 23, 2023
joe4dev
force-pushed
the
lambda-invocation-loop-rework
branch
4 times, most recently
from
August 31, 2023 08:30
79a7c08
to
0c0e31f
Compare
joe4dev
force-pushed
the
lambda-invocation-loop-rework
branch
5 times, most recently
from
September 5, 2023 09:38
91b8a32
to
46a4a46
Compare
joe4dev
force-pushed
the
lambda-invocation-loop-rework
branch
from
September 7, 2023 10:16
994726e
to
463a67f
Compare
joe4dev
requested review from
bentsku,
thrau,
dominikschubert,
dfangl,
pinzon and
simonrw
as code owners
September 12, 2023 11:29
dominikschubert
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it 🚀
dfangl
approved these changes
Sep 12, 2023
This was referenced Sep 15, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
semver: minor
Non-breaking changes which can be included in minor releases, but not in patch releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Goals
Changes
This PR basically re-writes the data plane (i.e., everything related to environment assignment and invocation scheduling) of our new Lambda provider. The re-architected implementation is inspired based on the real architecture of AWS Lambda explained at AWS re:Invent 2022 - A closer look at AWS Lambda (SVS404-R).
Invocation model
Images from AWS: https://youtu.be/0_jfH6qijVY
Synchronous invocation
Asynchronous Invocation
More details to follow ...
Internal Documentation
Testing
This PR adds more AWS-validated tests and fixes some existing tests (e.g., fixes timing assumptions, and makes async tests faster). One example: We previously triggered the DLQ destination upon every failed invocation rather than only after the last retry.
TODO
See internal documentation Collection of Meeting Notes (Notion)