Fix resolving pseudo-parameters in Fn::Sub #8974

dominikschubert · 2023-08-23T20:26:48Z

Motivation

Fixes the issue multiple people experienced where pseudo-parameter couldn't be resolved correctly when used in Fn::Sub.

Example error message: Unable to resolve attribute ref AWS::URLSuffix

Resolves #8726

check for pseudo-parameter when resolving a placeholder in a sub string and resolve them recursively

pinzon

LGTM

coveralls · 2023-08-23T21:03:34Z

coverage: 80.712% (-0.02%) from 80.731% when pulling 377a076 on fix_cfn-sub-pseudoparams into b96c100 on master.

github-actions · 2023-08-23T21:51:51Z

      2 files       2 suites 1h 27m 7s ⏱️
2 111 tests 1 662 ✔️ 449 💤 0 ❌
2 112 runs 1 662 ✔️ 450 💤 0 ❌

Results for commit 377a076.

fix resolving pseudo-parameters in Fn::Sub

377a076

dominikschubert requested a review from pinzon as a code owner August 23, 2023 20:26

dominikschubert self-assigned this Aug 23, 2023

dominikschubert requested a review from simonrw as a code owner August 23, 2023 20:26

dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Aug 23, 2023

pinzon approved these changes Aug 23, 2023

View reviewed changes

dominikschubert merged commit 040130b into master Aug 24, 2023
27 of 28 checks passed

dominikschubert deleted the fix_cfn-sub-pseudoparams branch August 24, 2023 05:30