refresh SES snapshots #8991
Merged
refresh SES snapshots #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
commented
Aug 25, 2023
| f"Invalid tag value <{tag_value}>: only alphanumeric ASCII characters, '_', and '-' are allowed.", | ||
| ) | ||
|
|
||
| response = call_moto(context) |
There was a problem hiding this comment.
moved the tag validation before the call to moto because it seems AWS validates the tags before anything else
bentsku
added
aws:ses
bentsku
force-pushed
the
ses-refresh-snapshots
branch
from
9ef5d7e
to
5959b29
Compare
viren-nadkarni
approved these changes
Aug 28, 2023
bentsku
force-pushed
the
ses-refresh-snapshots
branch
from
5959b29
to
a1c7b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refreshing SES snapshots which were older than 3 months
Changes
Spotted a little change in logic with AWS for some tests and adapted them.
Adapted some tests to run against AWS.
Some tests are still in an
needs_fixingstate because they can't run against AWS, it might beunknowninstead though because of the sandbox account not allowing us to use everything.