Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS::IAM::InstanceProfile creation #9022

Merged
merged 1 commit into from Aug 30, 2023
Merged

Fix AWS::IAM::InstanceProfile creation #9022

merged 1 commit into from Aug 30, 2023

Conversation

dominikschubert
Copy link
Member

Motivation

A recent PR (#9011) introduced a regression for the AWS::IAM::InstanceProfile resource type.

Changes

  • fixes the create handler for AWS::IAM::InstanceProfile to return a success state and to consider the path as optional

@dominikschubert dominikschubert self-assigned this Aug 30, 2023
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Aug 30, 2023
@coveralls
Copy link

Coverage Status

coverage: 80.443% (+0.07%) from 80.37% when pulling acfc5e3 on fix_cfn-aws-iam-instanceprofile into 5b16d3b on master.

@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 28m 53s ⏱️
2 148 tests 1 674 ✔️ 474 💤 0 ❌
2 149 runs  1 674 ✔️ 475 💤 0 ❌

Results for commit acfc5e3.

dfangl
dfangl approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@dfangl dfangl merged commit 95fed35 into master Aug 30, 2023
28 of 29 checks passed
@dfangl dfangl deleted the fix_cfn-aws-iam-instanceprofile branch August 30, 2023 12:25
ashish1500616 pushed a commit to ashish1500616/localstack that referenced this pull request Aug 31, 2023
@dominikschubert @ashish1500616
fix AWS::IAM::InstanceProfile (localstack#9022)
f811884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dominikschubert @coveralls @dfangl