Add SQS/Lambda interaction. #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
|
any chance this gets merged soon? would like to use it... |
|
Thanks for this PR @mattfrohligeraver ! Only added a minor nitpick comment - can we address it before merging? thx |
whummer
reviewed
Aug 29, 2018
| new_response = Response() | ||
| new_response._content = ( | ||
| '<?xml version="1.0"?>' | ||
| '<SendMessageResponse xmlns="http://queue.amazonaws.com/doc/2012-11-05/">' |
There was a problem hiding this comment.
nit: Instead of inlining the entire XML string here, can we define a root level constant at the top of the file? Also, we can reuse the xmlns namespace URL.
|
@whummer Thanks for the feedback. I have made the requested change. |
|
Great, thanks for updating the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently event notification configurations for lambda functions that use an SQS queue as the source are not taken into account. This PR adds that functionality based on the implementation of a similar Kinesis/Lambda interaction.