Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container fixture improvements #9048

Merged
merged 7 commits into from Sep 2, 2023
Merged

Container fixture improvements #9048

merged 7 commits into from Sep 2, 2023

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Sep 1, 2023

Motivation

The container fixtures created in ... were:

  • only usable in the bootstrap subdir, but we need them in the cli subdir (amongst others)
  • are too widely scoped (session scoped ContainerFactory)
  • uses a confusing fixture order (cleanups)
  • did not store the running container, so automatic cleanup was not possible

Changes

Fix the items above

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Sep 1, 2023
@simonrw simonrw self-assigned this Sep 1, 2023
@simonrw simonrw requested a review from thrau September 1, 2023 20:40
simonrw
simonrw commented Sep 1, 2023
View reviewed changes
localstack/testing/pytest/container.py
@@ -86,7 +83,7 @@ def remove_all_containers(self):
)


@pytest.fixture(scope="session")
@pytest.fixture
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This or class scope?

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 32m 58s ⏱️
2 152 tests 1 676 ✔️ 476 💤 0 ❌
2 153 runs  1 676 ✔️ 477 💤 0 ❌

Results for commit 79e9eaf.

@simonrw simonrw marked this pull request as ready for review September 2, 2023 21:24
thrau
thrau approved these changes Sep 2, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for fixing 💯

@thrau thrau merged commit 6c30a86 into master Sep 2, 2023
26 checks passed
@thrau thrau deleted the container-fixture-improvements branch September 2, 2023 22:49
@simonrw simonrw mentioned this pull request Sep 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

@simonrw simonrw

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonrw @thrau