Migrate DNS server to community #9049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need these in the CLI tests
simonrw
added
the
semver: minor
This causes a failure with the CLI tests because of a port conflict.
This reverts commit 000f842.
|
podman tests have been broken for a while |
dfangl
reviewed
Sep 7, 2023
This ensures the internal state of the server is in sync with the actual server
dfangl
approved these changes
Sep 7, 2023
dfangl
requested changes
Sep 7, 2023
simonrw
changed the title
simonrw
changed the title
Also don't mutate global state (config) since this may affect other things...
To stop a breaking change
serialbandicoot
pushed a commit
to serialbandicoot/localstack
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to simplify network configuration. A point of confusion is that
localhost.localstack.cloudis publically registered, and resolves to127.0.0.1. When communicating between docker containers, this is an issue - trying to connect to e.g. an opensearch domain with url*.localhost.localstack.cloudreturned by LocalStack will attempt to connect to the "application" container, rather than LocalStack.Recently we have upgraded the DNS server provided by LocalStack Pro to dynamically resolve the IP address of the LocalStack container based on request subnet, but this functionality was only available in Pro.
With this PR we bring the DNS server from Pro to LocalStack community. This change brings along with it increased test coverage.
Changes
DNS_PORT) can be bound on the host, publish the docker port using the CLIlocalstack.services.dns_servertolocalstack.dns.serverto group core resources (e.g.http,dns, etc.) at the top of the treeTesting
DNS_ADDRESS=127.0.0.1 localstack startdig @127.0.0.1 localhost.localstack.cloudand a valid response is returneddig @<ip of localstack container> localhost.localstack.cloudand the IP address of the container should be returnedTODO
What's left to do: