Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix escaping backslash in comments #9057

Merged
merged 1 commit into from Sep 5, 2023
Merged

fix escaping backslash in comments #9057

merged 1 commit into from Sep 5, 2023

Conversation

alexrashed
Copy link
Member

Motivation

The latest version of botocore contains a change in the spec (namely boto/botocore@29dbcb9) which contains a backslash in the documentation of an operation of SESv2.
API code generated based on this botocore version fail the linting check, because the generated docstring contains the `\` (which violates flake8's W605).

Changes

This PR just adds the backslash to the list of characters which need to be escaped in the docstring to fix the linting errors.

Testing

The SESv2 API has been generated based on the change and it passes the linting.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Sep 4, 2023
@alexrashed alexrashed added this to the 2.3 milestone Sep 4, 2023
@alexrashed alexrashed self-assigned this Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 30m 37s ⏱️
2 152 tests 1 676 ✔️ 476 💤 0
2 153 runs  1 676 ✔️ 477 💤 0

Results for commit aa71d8c.

♻️ This comment has been updated with latest results.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find, LGTM!

@thrau thrau merged commit 1910b2e into master Sep 5, 2023
27 checks passed
@thrau thrau deleted the fix-asf-updates branch September 5, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants