Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate and refactor cloudwatch tests #9117

Merged
merged 3 commits into from Sep 12, 2023
Merged

Validate and refactor cloudwatch tests #9117

merged 3 commits into from Sep 12, 2023

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Sep 12, 2023 •
edited

Motivation

These tests were quite flaky in CI, so I tried to make them a bit more robust now 😅

Changes

  • Remove all unknown markers and replace with proper markers.
  • Any tests that would've been needs_fixing have been adapted/fixed to be compatible with AWS.
  • Skip test_put_metric_alarm instead of xfailing because it always fails with localstack and the test is usually running for 3 minutes.

TODO

What's left to do:

  • might need to adjust snapshots due to transformer change

@dominikschubert dominikschubert self-assigned this Sep 12, 2023
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Sep 12, 2023
@dominikschubert dominikschubert marked this pull request as ready for review September 12, 2023 08:57
@dominikschubert dominikschubert removed the request for review from silv-io September 12, 2023 08:57
steffyP
steffyP reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing + improving the tests! 🙏 🙇‍♀️
I am quite certain some tests will fail because of the Namespace and MetricName replacement.

localstack/testing/snapshots/transformer_utility.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 12, 2023 •
edited

LocalStack Community integration with Pro

       2 files         2 suites   1h 19m 1s ⏱️
2 181 tests 1 698 ✔️ 483 💤 0 ❌
2 182 runs  1 698 ✔️ 484 💤 0 ❌

Results for commit c8cb476.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Coverage Status

coverage: 79.751% (+0.004%) from 79.747% when pulling c8cb476 on validate-cloudwatch-tests into 1727a86 on master.

@dominikschubert dominikschubert merged commit 74b3728 into master Sep 12, 2023
26 checks passed
@dominikschubert dominikschubert deleted the validate-cloudwatch-tests branch September 12, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dominikschubert @coveralls @steffyP