Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal developer configuration from CONFIG_ENV_VARS #9135

Merged
merged 1 commit into from Sep 13, 2023

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Sep 13, 2023

Motivation

Using LAMBDA_DEV_PORT_EXPOSE within Docker breaks Lambda leading to a connection error because the LocalStack container cannot reach the Lambda container:

Failed invocation MyHTTPConnectionPool(host='127.0.0.1', port=58301): Max retries exceeded with url: /invoke (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0xffff40fa18a0>: Failed to establish a new connection: [Errno 111] Connection refused'))

/cc @whummer

Changes

  • Remove the internal developer configuration LAMBDA_DEV_PORT_EXPOSE from CONFIG_ENV_VARS
  • Add a code comment to clarify the intent of CONFIG_ENV_VARS

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Sep 13, 2023
@joe4dev joe4dev added this to the 2.3 milestone Sep 13, 2023
@joe4dev joe4dev self-assigned this Sep 13, 2023
@joe4dev joe4dev requested a review from thrau as a code owner September 13, 2023 10:22
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the quick fix @joe4dev , and for updating the comments, to make it more clear 🙌

@coveralls
Copy link

Coverage Status

coverage: 79.932% (+0.07%) from 79.862% when pulling 4bc6a5a on support/remove-dev-config-from-config-vars into b93486d on master.

@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 23m 5s ⏱️
2 199 tests 1 705 ✔️ 494 💤 0
2 200 runs  1 705 ✔️ 495 💤 0

Results for commit 4bc6a5a.

@joe4dev joe4dev merged commit 76498d4 into master Sep 13, 2023
30 checks passed
@joe4dev joe4dev deleted the support/remove-dev-config-from-config-vars branch September 13, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants