simplify log printing in localstack start command

[thrau]

Motivation

An enterprise user noticed that when using EXTENSION_DEV_MODE=1 is set, the information is not printed correctly to the logs when using localstack start.
I couldn't really find the root cause, but it seems to have something to do with echo calls in the docker-entrypoint.sh not showing up in the default outfile, which is the mechanism we use to dump the docker logs.
We then listen on those logs using a FileListener.

That seemed a bit roundabout to me now that we have stream_container_logs, so I removed the FileListener logic alltogether, and just wait for the container to start and then start printing the logs from there.
Since docker logs -f prints all the previous logs, it's a pretty robust solution.

I also found an issue where we didn't pass the Container instance to the LocalstackContainerServer.

Changes

• Remove FileListener and replace it with ContainerLogPrinter
• Change the bootstrap logic of localstack start accordingly
• Update LocalstackContainerServer to also take a Container instance

[coveralls]

coverage: 80.08% (-0.05%) from 80.128% when pulling ccf50bd on simplify-start-logging into 858bbf2 on master.

[github-actions]

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 14m 18s ⏱️ - 2m 13s
2 209 tests ±0  1 713 ✔️ ±0  496 💤 ±0  0 ❌ ±0 
2 210 runs  ±0  1 713 ✔️ ±0  497 💤 ±0  0 ❌ ±0 

Results for commit 2e62049. ± Comparison against base commit 858bbf2.

[simonrw]

Does this mean we can remove default_run_outfile as well?

[thrau]

@simonrw i think i would argue to keep it since it keeps the log file of the last run around in the localstack volume which may be useful. since we remove the container there would be no way of inspect logs after it shuts down

[simonrw]

Nice set of changes, and the implementation seems to work nicely