introduce request finalizers into handler chain #9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
added
the
semver: minor
thrau
force-pushed
the
request-finalizers
branch
from
e0395a2
to
f9451e6
Compare
|
Changes unknown |
bentsku
approved these changes
Dec 19, 2023
|
|
||
| self.stopped = False | ||
| self.terminated = False | ||
| self.finalized = False |
There was a problem hiding this comment.
q: when is this set to True? or how can you set it to True?
There was a problem hiding this comment.
A handler could set it. It's just a way to control things for tests oder other systems that may not want/need familzers
There was a problem hiding this comment.
Ah right yes thanks! The Handler has access to the HandlerChain. Thanks for answering 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the persistence plugin (and perhaps elsewhere), we are using a pattern where we are acquiring locks in request handlers, and freeing them in response handlers, to lock certain things across a request invocation. This can lead to locks never being freed, when handlers (like the CORS enforcer) call
chain.terminate(), which prevents response handlers from being called.This PR introduces the concept of finalizers into the handler chain, which are always called, even if the chain is terminated. Obviously these should be used sparsely, and only run essential finalization code.
Changes
finalizer: List[Handler]attribute