Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 872; fixes query param parsing for s3 notification put #921

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

payaaam
Copy link
Contributor

@payaaam payaaam commented Sep 7, 2018

Fix query parameter parsing in s3 put bucket notification configuration api call.

Details on issue can be found here...
#872

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.599% when pulling ff29d05 on payaaam:s3-notification-fix into fcad0c1 on localstack:master.

@chadbean
Copy link

chadbean commented Sep 7, 2018

Currently blocked on this. Any timeline on getting this merged? Anything I can do to expedite it?

@gt53
Copy link

gt53 commented Sep 10, 2018

Would love to see this fix available soon.

@whummer
Copy link
Member

whummer commented Sep 12, 2018

Great, thanks for this fix @payaaam !

@whummer whummer merged commit 65ded5d into localstack:master Sep 12, 2018
Stovoy pushed a commit to Nextdoor/localstack that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants