Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add develop mode to dev script #9274

Merged
merged 1 commit into from Oct 2, 2023
Merged

Add develop mode to dev script #9274

merged 1 commit into from Oct 2, 2023

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Oct 2, 2023

Motivation

It is sometimes nice to attach a remote debugger to a running container. For this we can use the DEVELOP=1 flag with the CLI, which

  • installs debugpy into the container before infrastructure startup, and
  • publishes port 5678 (the default DAP port) to the host.

These two commands can be added to the debug script, however it is marginally annoying. And of course we know that developers hate to be mildy annoyed... 😂

Changes

  • Add a --develop/--no-develop flag to the CLI which performs the two above steps

Testing

python -m localstack.dev.run --develop`

should allow for remote debugging via the DAP protocol. Specifically it should:

  • install debugpy into the container, and
  • publish port 5678

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Oct 2, 2023
@simonrw simonrw self-assigned this Oct 2, 2023
@simonrw simonrw marked this pull request as ready for review October 2, 2023 09:35
@simonrw simonrw requested a review from thrau October 2, 2023 09:35
@coveralls
Copy link

Coverage Status

coverage: 82.997% (-0.01%) from 83.008% when pulling 02f9d71 on dev-develop-mode into dcd9f15 on master.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 11m 36s ⏱️ - 2m 7s
2 222 tests ±0  1 725 ✔️ ±0  497 💤 ±0  0 ±0 
2 223 runs  ±0  1 725 ✔️ ±0  498 💤 ±0  0 ±0 

Results for commit 02f9d71. ± Comparison against base commit dcd9f15.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I would argue for the dev start script this should be the default

@simonrw simonrw merged commit 4cddb8f into master Oct 2, 2023
31 checks passed
@simonrw simonrw deleted the dev-develop-mode branch October 2, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants