Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdk-helper for lambdas with dependency #9275

Merged
merged 3 commits into from Oct 4, 2023
Merged

Add cdk-helper for lambdas with dependency #9275

merged 3 commits into from Oct 4, 2023

Conversation

steffyP
Copy link
Member

@steffyP steffyP commented Oct 2, 2023

Motivation

Adding utility function that package lambdas for python or nodeJS with additional resources or dependencies.
The code is directly uploaded to an S3 bucket, which can be used as source for the lambda-creation then.
This PR depends on #9251 and need to be rebased.

Changes

  • Introducing cdk_lambda_helper with utility for python and nodeJS lambda
  • Refactoring existing scenario tests to use the utility functions

TODO

What's left to do:

@steffyP steffyP added the semver: patch Non-breaking changes which can be included in patch releases label Oct 2, 2023
@coveralls
Copy link

coveralls commented Oct 2, 2023

Coverage Status

coverage: 82.967% (+0.04%) from 82.926% when pulling 3a60570 on cdk-helper into c5e8659 on master.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 19m 11s ⏱️
2 217 tests 1 722 ✔️ 495 💤 0
2 218 runs  1 722 ✔️ 496 💤 0

Results for commit d54f9ef.

♻️ This comment has been updated with latest results.

@steffyP steffyP marked this pull request as ready for review October 3, 2023 12:31
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steffyP steffyP merged commit f5be27b into master Oct 4, 2023
9 of 10 checks passed
@steffyP steffyP deleted the cdk-helper branch October 4, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants