New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade werkzeug to version 3 #9276
Conversation
3b041c0
to
c172fa4
Compare
c172fa4
to
0c0b62e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
just thinking that updating the constraints of core dependencies like this may affect extensions in unexpected ways. not sure what to do about it right now or how to deal with it moving forward, but something we should consider
Motivation
This PR upgrades Werkzeug to version 3 and fixes some issues caused by the removal of deprecations (or other breaking changes with version 3).
This PR removes the pin (avoiding the upgrade) added with #9272.
Changes
setup.cfg
.Headers
object raises aBadRequestKeyError
if a key is not of typestr
.charset
andencoding_errors
on theMap
(they have been removed).Testing
As soon as the pipeline is green again (and the upgrade is tested with LocalStack Pro), this upgrade is safe to be merged.
TODO