Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade werkzeug to version 3 #9276

Merged
merged 4 commits into from Oct 3, 2023
Merged

upgrade werkzeug to version 3 #9276

merged 4 commits into from Oct 3, 2023

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Oct 2, 2023

Motivation

This PR upgrades Werkzeug to version 3 and fixes some issues caused by the removal of deprecations (or other breaking changes with version 3).
This PR removes the pin (avoiding the upgrade) added with #9272.

Changes

  • Updates minimum version in setup.cfg.
  • Fixes some issues which came up with the new major release:
    • Decode headers when populating the WSGI request headers from the ASGI requests and when forwarding requests.
    • Removes the usage of charset and encoding_errors on the Map (they have been removed).

Testing

As soon as the pipeline is green again (and the upgrade is tested with LocalStack Pro), this upgrade is safe to be merged.

TODO

  • Make sure all tests in the pipeline are 💚
    • I executed a full run (amd64, arm64, community tests) of our Pro pipeline. All 💚.

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Oct 2, 2023
@alexrashed alexrashed added this to the 3.0 milestone Oct 2, 2023
@alexrashed alexrashed self-assigned this Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 23m 17s ⏱️ + 13m 14s
2 222 tests ±0  1 725 ✔️ ±0  497 💤 ±0  0 ±0 
2 223 runs  ±0  1 725 ✔️ ±0  498 💤 ±0  0 ±0 

Results for commit 0c0b62e. ± Comparison against base commit 6e8915a.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Coverage Status

coverage: 83.034% (+0.002%) from 83.032% when pulling 0c0b62e on upgrade-werkzeug-3 into 6e8915a on master.

@alexrashed alexrashed marked this pull request as ready for review October 3, 2023 09:29
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

just thinking that updating the constraints of core dependencies like this may affect extensions in unexpected ways. not sure what to do about it right now or how to deal with it moving forward, but something we should consider

@thrau thrau merged commit be3f22d into master Oct 3, 2023
30 checks passed
@thrau thrau deleted the upgrade-werkzeug-3 branch October 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants