New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add /_localstack/info endpoint for basic infos about the instance #9290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is going to be super-useful when trying to help our users! 🚀
|
||
|
||
def is_license_activated() -> bool: | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe it would make sense to separate the imports here:
- First try to import anything super-stable from ext.
- return false if it's not possible
- Then try to import the specific method.
- list a prominent error in this case, because that would mean that this code stopped working because of a refactoring, not because the package is missing
This is great! Thanks for the addition 🙌 |
Motivation
Several other localstack systems need access to basic information about the running instance beyond the health status. Much like
docker info
, this new endpoint aims to provide this information.Example:
Changes
/_localstack/info
endpointedition
key also to the health endpoint, since that has long since been requestedTesting
curl -s https://localhost.localstack.cloud:4566/_localstack/info | jq .