CFn: allow for pro resource provider overrides #9333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
2 tasks
simonrw
force-pushed
the
cfn/resource-provider-override
branch
2 times, most recently
from
0f14be8
to
980dd44
Compare
dominikschubert
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
I'm not 100% sure I like the approach with two different plugin managers, since it feels like we shouldn't need it.
An alternative could be appending a certain suffix the the plugin name when coming from ext and then handling that logic in the community plugin manager directly.
For now I don't really want to block this too much, especially since we can re-evaluate this setup at a later stage without any user-facing changes. So feel free to merge as is!
Comment on lines
773
to
778
| LOG.debug( | ||
| ( | ||
| "Failed to load resource type %s from pro as a ResourceProvider. " | ||
| "Maybe this resource is implemented in community." | ||
| ), | ||
| resource_type, |
There was a problem hiding this comment.
I feel like this is a bit too noisy for community usage.
simonrw
force-pushed
the
cfn/resource-provider-override
branch
2 times, most recently
from
b5f4c84
to
40bb7fe
Compare
simonrw
force-pushed
the
cfn/resource-provider-override
branch
from
40bb7fe
to
926cee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We disabled AWS::ECR::Repository in #9315 because we did not have an override system for resource providers in community vs pro. In particular, we had:
GenericBaseModelsubclassResourceProviderGenericBaseModelsubclassIn this case, the community resource provider was being chosen, rather than the pro
GenericBaseModelsubclass.Changes
Most of the changes to allow us to revert #9315 have been made in the pro repository. In addition, we are trying to handle the case where we have pro and community resource providers.
TODO