Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CODEOWNERS #9379

Merged
merged 2 commits into from Oct 19, 2023
Merged

update CODEOWNERS #9379

merged 2 commits into from Oct 19, 2023

Conversation

alexrashed
Copy link
Member

Motivation

We are more and more using the CODEOWNERS file in order to define code ownership in a machine readable way, which then can be used by different tools.
This can be GitHub by using it to auto-assigning PR reviewers, but it can also be used by tooling on our side in order to implement some kind of automation / notifications / ... around it.
This PR is another iteration on reducing the amount of uncovered files in this repo.
The enhancements were driven by the validation results created with mszostok/codeowners-validator.

Changes

  • Restructure the CODEOWNERS file a bit.
  • Add a few more sections / directories / files.

/cc affected codeowners @HarshCasper @thrau @dfangl @dominikschubert @steffyP

@alexrashed alexrashed added the area: ci Running LocalStack in CI environments label Oct 18, 2023
@alexrashed alexrashed added this to the 3.0 milestone Oct 18, 2023
@alexrashed alexrashed self-assigned this Oct 18, 2023
@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Oct 18, 2023
@coveralls
Copy link

coveralls commented Oct 18, 2023

Coverage Status

coverage: 82.996% (-0.002%) from 82.998% when pulling 049c12d on update-codeowners into 13e48bb on master.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating! added a few comments

CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
@alexrashed
Copy link
Member Author

Thanks @thrau for the review and the comments!
@dominikschubert and @dfangl: Could you please take a quick look and confirm that these changes are okay for you?
Thanks!

@alexrashed alexrashed merged commit ca43d39 into master Oct 19, 2023
18 checks passed
@alexrashed alexrashed deleted the update-codeowners branch October 19, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci Running LocalStack in CI environments semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants