Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfn: Add account ID and region awareness to Stacks and StackChangeSets #9418

Merged
merged 2 commits into from Oct 24, 2023

Conversation

viren-nadkarni
Copy link
Member

This PR ensures that CloudFormation Stacks and StackChangeSets have the correct ARNs when used in multi-account and multi-region setups.

@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Oct 20, 2023
@viren-nadkarni viren-nadkarni self-assigned this Oct 20, 2023
@coveralls
Copy link

Coverage Status

coverage: 82.925% (+0.001%) from 82.924% when pulling 87c056c on cfn-stack-account-region-awareness into e74ff43 on master.

@github-actions
Copy link

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 12m 16s ⏱️ + 3m 54s
2 262 tests ±0  1 687 ✔️ ±0  575 💤 ±0  0 ±0 
2 263 runs  ±0  1 687 ✔️ ±0  576 💤 ±0  0 ±0 

Results for commit 87c056c. ± Comparison against base commit e74ff43.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review October 23, 2023 05:48
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks innocent enough 👍

@viren-nadkarni viren-nadkarni merged commit e78814f into master Oct 24, 2023
27 checks passed
@viren-nadkarni viren-nadkarni deleted the cfn-stack-account-region-awareness branch October 24, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants