Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apigateway: add multi-account and region capability #9435

Merged
merged 4 commits into from Oct 23, 2023

Conversation

sannya-singal
Copy link
Contributor

@sannya-singal sannya-singal commented Oct 23, 2023

Motivation

When using values other than 000000000000 for account ID or us-east-1 for region, tests should still create the consequent resources in this accounts and region.

Changes

This PR fixes all the failing tests in tests/aws/services/apigateway/test_apigateway_extended.py by adding region and account id to the helper functions.

@sannya-singal sannya-singal added the semver: patch Non-breaking changes which can be included in patch releases label Oct 23, 2023
@sannya-singal sannya-singal self-assigned this Oct 23, 2023
@sannya-singal sannya-singal marked this pull request as ready for review October 23, 2023 06:43
@coveralls
Copy link

coveralls commented Oct 23, 2023

Coverage Status

coverage: 82.931%. remained the same when pulling a3f155e on apigw_extended into d2837c1 on master.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 8m 24s ⏱️
2 263 tests 1 688 ✔️ 575 💤 0
2 264 runs  1 688 ✔️ 576 💤 0

Results for commit a3f155e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this 🚀

@sannya-singal sannya-singal merged commit 6e894e0 into master Oct 23, 2023
27 checks passed
@sannya-singal sannya-singal deleted the apigw_extended branch October 23, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants