fix ASF update action if there are no changes #9436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With https://github.com/localstack/localstack-ext/pull/2217, we changed to
ruff
which replaces a bunch of tools (flake8
,isort
,autoflake
). Previously, these tools were directly called in the ASF scaffold and the result of the code generation was already perfectly formatted.ruff
cannot be called from Python code on in-memory strings, which is why we switched to ourformat-modified
make
target.Turns out, the target does not work in case there are no changes (since then black does not get any input).
This PR slightly modifies the ASF update action such that this issue is prevented.
Changes
format-modified
target is only executed if there are changes in the repo.Testing